Skip to content

fix(ui5-search): improve arrow navigation with grouping #12083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 14, 2025

Conversation

dobrinyonkov
Copy link
Contributor

@dobrinyonkov dobrinyonkov commented Aug 7, 2025

Problem: Arrow keys don't work when navigating through suggestion groups without group headers.

What changed:

  • Updated search arrow up/down focus logic to use actual focusable items from the list (flat items, without groups), using the list's listItems getter
  • Move getFocusDomRef method to ListItemGroup and return first item if no header is set
  • Includes Cypress tests to verify the navigation behavior works as expected.

@dobrinyonkov dobrinyonkov changed the title fix(ui5-shellbar-search): focus on first suggestion item fix(ui5-shellbar-search): improve arrow navigation with grouping Aug 12, 2025
@dobrinyonkov dobrinyonkov changed the title fix(ui5-shellbar-search): improve arrow navigation with grouping fix(ui5-search): improve arrow navigation with grouping Aug 12, 2025
@dobrinyonkov dobrinyonkov force-pushed the fix/shellbar-search-first-item-focus branch from bdb5f5d to f8c528d Compare August 13, 2025 05:11
@dobrinyonkov dobrinyonkov requested a review from MapTo0 August 13, 2025 05:22
Copy link
Member

@ivoplashkov ivoplashkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on our side.

@kgogov kgogov self-requested a review August 14, 2025 10:22
@dobrinyonkov dobrinyonkov merged commit c428f77 into main Aug 14, 2025
12 checks passed
@dobrinyonkov dobrinyonkov deleted the fix/shellbar-search-first-item-focus branch August 14, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants